How do you know you should break up with someone? Should I break up with this guy?

This guy if selfish, controlling, sometimes annoying. grumpy and upsets me quite a bit. He does have a good side to him which I really enjoy but I am sick of him and his selfish ways. I know I will miss him lots and maybe even regret it so I'm not sure if it's best for me. The other thing is his dad has recently passed away so I find this a bad time to take any action as I don't want to cause him anymore pain. I do believe he loves me and I guess I do love him. What do I do?